Resolve LLM API Base and Models#317
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR refactors LLM model name handling to separate concerns between configuration and API calls. Previously, Key Changes:
The refactoring ensures model names are consistently handled across the codebase and fixes issues with provider-specific features like vision support, reasoning, and prompt caching detection. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: d2c99ea |
…ability names - Replace fragile prefix matching with explicit STRIX_MODEL_MAP - Add resolve_strix_model() returning (api_model, canonical_model) - api_model (openai/ prefix) for API calls to OpenAI-compatible Strix API - canonical_model (actual provider name) for litellm capability lookups - Centralize resolution in LLMConfig instead of scattered call sites
0xallam
approved these changes
Feb 20, 2026
carcraze
pushed a commit
to carcraze/strix
that referenced
this pull request
Mar 10, 2026
Josz009
pushed a commit
to Josz009/strix
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.