Skip to content

Simplify tool file copying in Dockerfile#387

Merged
0xallam merged 1 commit into
mainfrom
0xallam-patch-1
Mar 22, 2026
Merged

Simplify tool file copying in Dockerfile#387
0xallam merged 1 commit into
mainfrom
0xallam-patch-1

Conversation

@0xallam

@0xallam 0xallam commented Mar 22, 2026

Copy link
Copy Markdown
Member

Removed specific tool files from Dockerfile and added a directory copy instead.

Removed specific tool files from Dockerfile and added a directory copy instead.
@greptile-apps

greptile-apps Bot commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR simplifies the containers/Dockerfile by replacing seven explicit COPY statements for individual files and subdirectories under strix/tools/ with a single COPY strix/tools/ /app/strix/tools/ directive. This reduces maintenance overhead — new tool directories no longer require a corresponding Dockerfile update.

Key observations:

  • The change is a clean simplification with no structural risk.
  • Several tool subdirectories that were previously absent from the image (agents_graph, finish, load_skill, reporting, thinking, todo, web_search) will now be included. This is likely an intentional fix to a stale Dockerfile, but worth confirming since those tools will now be available inside the container.
  • No other parts of the build are affected.

Confidence Score: 4/5

  • Safe to merge once the team confirms the newly included tool directories are intentional.
  • The change is mechanically correct and a genuine simplification. The only open question is whether the 7 previously-omitted subdirectories should now be in the image — if intentional, this is a clean 5. Keeping it at 4 to prompt explicit confirmation of that behaviour change.
  • containers/Dockerfile — confirm all newly copied tool subdirectories (agents_graph, finish, load_skill, reporting, thinking, todo, web_search) are intended to be included in the image.

Important Files Changed

Filename Overview
containers/Dockerfile Replaces 7 explicit COPY statements for strix/tools with a single COPY strix/tools/ /app/strix/tools/, which now includes several tool subdirectories (agents_graph, finish, reporting, thinking, todo, web_search, load_skill) that were previously omitted from the image.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: containers/Dockerfile
Line: 176

Comment:
**Previously omitted tool directories now included**

The old Dockerfile explicitly listed only 6 subdirectories (`browser`, `file_edit`, `notes`, `python`, `terminal`, `proxy`). The new `COPY strix/tools/ /app/strix/tools/` will also include the following directories that were previously **not** copied into the image:

- `strix/tools/agents_graph/`
- `strix/tools/finish/`
- `strix/tools/load_skill/`
- `strix/tools/reporting/`
- `strix/tools/thinking/`
- `strix/tools/todo/`
- `strix/tools/web_search/`

If these were intentionally excluded before (e.g., work-in-progress, not yet wired into the runtime), this change silently activates them in the image. Worth confirming the intent — if this is the desired fix it's great, but a brief note in the PR description would add clarity.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "Simplify tool file copying in Dockerfile" | Re-trigger Greptile

Comment thread containers/Dockerfile
@0xallam 0xallam merged commit b6a0a94 into main Mar 22, 2026
2 checks passed
@0xallam 0xallam deleted the 0xallam-patch-1 branch March 22, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant