Skip to content

Conversation

@max-amb
Copy link

@max-amb max-amb commented Dec 31, 2025

Fixes #9937

Not sure if error message could be better named

@max-amb max-amb marked this pull request as draft December 31, 2025 14:11
@max-amb max-amb marked this pull request as ready for review December 31, 2025 14:25
@max-amb
Copy link
Author

max-amb commented Dec 31, 2025

I am confused why the windows test doesn't work, the code in unix.rs and windows.rs seems the same to me. Can anyone help?

@oech3
Copy link
Contributor

oech3 commented Jan 1, 2026

csplit of main's code might help

@max-amb
Copy link
Author

max-amb commented Jan 1, 2026

csplit does this differently, with

        let file = File::open(file_name)
            .map_err_context(|| format!("cannot open {} for reading", file_name.quote()))?;
        Ok(csplit(&options, &patterns, BufReader::new(file))?)

in csplit.rs, 633-635.
It doesn't differentiate between unix and windows as well.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants