fix(fold): use buffered read to prevent hang on infinite streams like /dev/zero #9966
+49
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9845
The previous implementation of
foldattempted to read input line-by-line usingread_until. When processing infinite streams without newlines (such as/dev/zero), this caused the internal buffer to grow indefinitely, leading to a hang or OOM (Out of Memory) crash.Changes
fold_fileto use a fixed-size stack buffer (8KB) andRead::readinstead ofBufRead::read_until./dev/null(guarded by#[cfg(unix)]to avoid Windows CI failures).Verification
fold /dev/zerono longer hangs and streams output correctly.cargo test --package uu_foldpasses.