date:UTF-8 checks exist to keep custom date formats binary-safe #9972
+161
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement support for preserving byte sequences in date command output when dealing with invalid UTF-8 in format arguments or formatted strings. This prevents failures on non-UTF-8 data, especially on Unix systems, by introducing OutputEncoding enum (Utf8/BytePreserving), updating format parsing to use OsString, and adding write_formatted_output function. Addresses issues with binary-safe output in custom date formats.
Moved the ShortcutValueParser import after the unix-specific import to better organize platform-specific and general imports in date.rs.
Add #[cfg_attr(not(unix), allow(dead_code))] to OutputEncoding::BytePreserving, CustomFormatError::InvalidUtf8, locale_output_encoding(), and decode_byte_preserving() to allow these items to be unused on non-Unix systems without triggering warnings. This improves code quality and reduces noise in builds on unsupported platforms.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new OutputEncoding enum, byte-preserving helpers, and UTF-8 checks exist to keep custom date formats binary-safe.
related
#9959