df: add binfmt_misc to is_dummy_filesystem #9975
Open
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
van-sprundel
force-pushed
the
df-binfmt-misc
branch
from
f4a69ad to
c3c297e
Compare
|
GNU testsuite comparison: |
van-sprundel
force-pushed
the
df-binfmt-misc
branch
from
c3c297e to
74e3b95
Compare
Contributor
|
You mignt need to add some words to |
van-sprundel
force-pushed
the
df-binfmt-misc
branch
from
74e3b95 to
c0212d6
Compare
|
GNU testsuite comparison: |
Contributor
|
Also for fsext.rs... |
Author
Oops, missed this one |
van-sprundel
force-pushed
the
df-binfmt-misc
branch
from
c28d376 to
4ff7eb9
Compare
sylvestre
reviewed
Jan 1, 2026
src/uucore/src/lib/features/fsext.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| #[cfg(all(unix, not(any(target_os = "aix", target_os = "redox"))))] |
Author
There was a problem hiding this comment.
I matched the test case to is_dummy_filesystem which has the same condition. My assumption was that this function would only exist on unix.
Should it also succeed on non-unix?
Contributor
There was a problem hiding this comment.
we don't care about aix
just remove it (in both places)
thanks
van-sprundel
force-pushed
the
df-binfmt-misc
branch
from
a345f8c to
961f548
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #9952
Was trying to reproduce the issue and saw that
binfmt_miscwas not marked as a dummy system. Seems like this should be the case.