Skip to content

Fix BigCommerce login - #889

Closed
slackerzz wants to merge 3 commits into
vercel:mainfrom
slackerzz:fix_bigcommerce_set_cookie_on_login
Closed

Fix BigCommerce login#889
slackerzz wants to merge 3 commits into
vercel:mainfrom
slackerzz:fix_bigcommerce_set_cookie_on_login

Conversation

@slackerzz

@slackerzz slackerzz commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Partially fix #888

@vercel

vercel Bot commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

@slackerzz is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
commerce-bigcommerce ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-commercejs ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-kibocommerce ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-local ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 2:34PM (UTC)
commerce-ordercloud ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-saleor ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-shopify ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-spree ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-swell ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
commerce-vendure ❌ Failed (Inspect) Nov 25, 2022 at 2:34PM (UTC)
@slackerzz

Copy link
Copy Markdown
Contributor Author

@cond0r now the problem is in packages/commerce/src/api/utils/index.ts where the validation against the customerSchema fails

@cond0r

cond0r commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Yes, I will investigate more and provide a fix by next week. From what I remember, login & Signup had some unresolved issues from the past. Also, during my quick tests, I saw that the validations from BigCommerce don't appear and show generic messages. That will be covered in my fix PR also.

@slackerzz

Copy link
Copy Markdown
Contributor Author

@cond0r changing the customerSchema to:

export const customerSchema = z.object({
  customer: z.object({
    id: z.string(),
    firstName: z.string(),
    lastName: z.string(),
    email: z.string().optional(),
    phone: z.string().optional(),
    company: z.string().optional(),
    notes: z.string().optional(),
    acceptsMarketing: z.boolean().optional(),
  })
})

seems to fix this issue

@cond0r

cond0r commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

Thank you! this will be addressed in #918

@cond0r cond0r closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants