Fix BigCommerce login - #889
Closed
slackerzz wants to merge 3 commits into
Closed
Conversation
Contributor
|
@slackerzz is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@cond0r now the problem is in packages/commerce/src/api/utils/index.ts where the validation against the customerSchema fails |
Contributor
|
Yes, I will investigate more and provide a fix by next week. From what I remember, login & Signup had some unresolved issues from the past. Also, during my quick tests, I saw that the validations from BigCommerce don't appear and show generic messages. That will be covered in my fix PR also. |
Contributor
Author
|
@cond0r changing the seems to fix this issue |
Contributor
|
Thank you! this will be addressed in #918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partiallyfix #888