Skip to content

fix(IconLayer): don't generateMipmaps before data loaded #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
felixpalmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(IconLayer): don't generateMipmaps before data loaded #9909

felixpalmer wants to merge 1 commit into from

Conversation

@felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Dec 9, 2025

Closes #9841

Background

#9241 added an unneeded call to generateMipmaps() that could execute before data was in the texture, causing corruption

Change List

  • Remove generateMipmaps() as _loadIcons() performs it after each texture load
@felixpalmer felixpalmer requested a review from ibgreen December 9, 2025 17:24
@coveralls
Copy link

coveralls commented Dec 9, 2025

Coverage Status

coverage: 91.055%. remained the same
when pulling 96f4979 on felix/premature-mipmaps
into 528bb50 on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@felixpalmer @coveralls