[chore]: Add Qwen DBO scenarios; fix #270 typos and mypy findings - #286
Open
yujuancao07 wants to merge 2 commits into
Open
[chore]: Add Qwen DBO scenarios; fix #270 typos and mypy findings#286yujuancao07 wants to merge 2 commits into
yujuancao07 wants to merge 2 commits into
Conversation
Add Qwen3 MoE and Qwen3.6 MoE DBO scenarios Signed-off-by: yujuancao07 <yujuancao07@gmail.com>
…w-up checks - Fix the 'determin' typo in attention_model_runner.py and add the missing SPDX headers to the three test files introduced with vllm-project#270. - Declare the connector/vllm_config/metadata attributes on AFDMetadataProviderMixin so the shared helpers type-check. - Narrow Optional control-plane/model/graph accesses in the FFN runners, replace the bool aggregated-key predicate with a sizes-tuple helper in cuda_graph.py, and type the duck-typed helpers as Any where the contract is dynamic (vLLM fakes, HF config, forward context). - Convert the dynamic fake-module attribute assignments in test_p2p_connector.py to Any-typed locals and fix the test fakes' annotations; all changed files pass mypy 3.10, ruff, and the affected unit suites. Signed-off-by: yujuancao07 <yujuancao07@gmail.com>
yujuancao07
requested review from
hsliuustc0106 and
jiangkuaixue123
as code owners
August 29, 2026 03:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the Qwen DBO weekly scenarios.
Fix the typos and mypy-3.10 findings that surfaced when the pre-commit
suite scanned the fix: gate GPU FFN graph replay on Attention run mode #270 changes
Scope
In scope
test-weekly.ymlstep contents and the matching README /design-doc wording. No runner or model-code changes.
determin→determinecomment fix; SPDX headers on thethree test files added with fix: gate GPU FFN graph replay on Attention run mode #270; mixin attribute declarations on
AFDMetadataProviderMixin; Optional narrowing (asserts / replay guards)in the FFN runners; duck-typed helpers annotated
Anywhere thecontract is dynamic; test-fake annotations. Every hunk maps to a
reported mypy/typos finding.
Out of scope
still an open design point), performance changes, new functionality.