MiniMax-M3 spec decoding Blackwell - #694
Open
faradawn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces hardware overrides for the 'blackwell' architecture in the MiniMax-M3 model configuration, specifying speculative decoding and attention settings. The review feedback correctly identifies that the CLI arguments --attention_config.backend and --attention_config.use_trtllm_attention are non-standard in vLLM and may cause server startup failures, recommending standard alternatives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Eagle3-GQA draft head and enable FLASHINFER + TRT-LLM attention for spec_decoding on Blackwell (B200/B300/GB200/GB300). Non-Blackwell NVIDIA stays on the standard Eagle3 head; AMD stays on TRITON_ATTN. Based on SemiAnalysisAI/InferenceX#2328 and SemiAnalysisAI/InferenceX#2337.