Create bindings for hipblasLt#510
Merged
vosen merged 3 commits intovosen:masterfrom Sep 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates bindings for the hipblasLt library and makes structural changes to support multiple HIP type conversions. It modifies the existing hip_type field from Option<Path> to a Vec<Path> allowing multiple From implementations for error type conversions, specifically enabling both rocblas_error and hipblasLtError to be converted to cublasError_t.
- Adds comprehensive hipblasLt bindings with error handling and type conversions
- Refactors
hip_typefield to support multiple Hip implementations - Fixes type references for
cublasComputeType_tin cublasLt modules
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zluda_bindgen/src/main.rs | Core binding generation logic including new hipblasLt generation and hip_type Vec refactoring |
| ext/hipblaslt-sys/* | New hipblasLt library bindings with build configuration and generated source |
| format/src/format_generated_blaslt.rs | Updated display formatting with corrected type references |
| cuda_types/src/cublaslt.rs | Removed duplicate type definitions and cleaned up structure |
| cuda_types/src/cublas.rs | Added hipblasLtError conversion implementation |
| cuda_macros/src/cublaslt.rs | Fixed cublasComputeType_t type references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zluda-violet
added a commit
to zluda-violet/ZLUDA
that referenced
this pull request
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate bindings for hipblasLt and make some changes to the bindings for cublasLt. Notably, the
hip_typeOptionis changed to aVec, so that multipleFromimplementations (forrocblas_errorandhipblasLtError) can be created forcublasError_t.