Implement cuStreamCreate#511
Merged
zluda-violet merged 1 commit intovosen:masterfrom Sep 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements the cuStreamCreate CUDA function by adding it to the function declarations and creating a corresponding implementation that maps to HIP's hipStreamCreateWithFlags.
- Added
cuStreamCreateto the CUDA function declarations list - Implemented the function in the stream module using HIP backend
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zluda/src/lib.rs | Added cuStreamCreate to the macro-generated function declarations |
| zluda/src/impl/stream.rs | Added create function implementation that wraps hipStreamCreateWithFlags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last non-blasLt function needed for llm.c. I've put this in its own PR to declutter the blasLt one.