Merge release/v1.9.0 to develop

[voxel51-bot]

Merge release/v1.9.0 to develop

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error handling to immediately halt processing upon error detection, preventing incomplete operations and improving system stability.

• Documentation

  • Added clarification on JSON serialization requirements for panel event return values with guidance for handling non-serializable types.

[coderabbitai]

Walkthrough

Added explicit early returns in two error-handling branches within the model evaluation panel loader to stop further processing after notifying errors; also added a warning in plugin docs clarifying that panel event return values must be JSON-serializable, with guidance to convert non-serializable types.

Changes

Cohort / File(s)	Summary
Error handler improvements plugins/panels/model_evaluation/__init__.py	Added explicit return statements immediately after notifications in two error-handling blocks: one after "Failed to load custom code subsets" in load_view and one after "You do not have permission to delete scenarios" in load_scenario.
Docs — panel event serialization warning docs/source/plugins/developing_plugins.rst	Inserted a warning in the Callbacks/Plausible section stating that all panel event return values must be JSON-serializable and advising conversion of non-serializable types; placed before examples for both builtin and custom panel events.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰 I nibble at bugs with careful care,
I tuck returns where errors tear,
A warning posted, tidy and spry,
JSON-ready hops — a joyful sigh! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description simply states "Merge release/v1.9.0 to develop." without providing any meaningful content from the required template. The description fails to address any of the required sections: it does not explain what changes are proposed, does not describe how the patch is tested, and does not include any release notes information or impact areas. This is essentially a placeholder description rather than a substantive explanation of the pull request.
Title Check	❓ Inconclusive	The PR title "Merge release/v1.9.0 to develop" describes the merge operation itself (which branches are involved) but does not convey the substantive changes being merged. The changeset includes error handling fixes in model evaluation code and new documentation about panel event serialization requirements. The title reads more as a generic branch merge operation rather than describing the primary changes a developer would care about when scanning PR history, making it too generic to clearly indicate what is actually being merged.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch merge/release/v1.9.0

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b883e5 and 9987776.

📒 Files selected for processing (1)

• docs/source/plugins/developing_plugins.rst (1 hunks)

🔇 Additional comments (1)

docs/source/plugins/developing_plugins.rst (1)

2887-2899: Well-placed documentation clarifying an important constraint.

The new warning clearly explains the JSON-serialization requirement for panel event return values and provides concrete guidance on converting non-serializable types. The placement immediately before the code examples is ideal for visibility.

Please verify that this constraint applies uniformly to all panel event types mentioned (both builtin events like on_load, on_unload, on_change_ctx, etc., and custom events). If there are any exceptions or nuances in how different event types handle return values, consider expanding the warning to clarify them.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}