Skip to content

Conversation

@ritch
Copy link
Contributor

@ritch ritch commented Oct 23, 2025

What changes are proposed in this pull request?

Make the plugin cache enabled by default.

How is this patch tested? If it is not, please explain why.

The cache has been tested thoroughly in fiftyone-teams.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

The plugin cache will now be enabled by default. Plugin developers should disable this by setting the corresponding config to false, which maintains hot reload support of operators and panels.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • Chores
    • Plugins cache is now enabled by default, improving plugin loading efficiency and performance.
@ritch ritch requested a review from a team as a code owner October 23, 2025 20:33
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Walkthrough

The default value for plugins_cache_enabled in FiftyOneConfig was changed from False to True, enabling the plugins cache by default when parsing configuration settings.

Changes

Cohort / File(s) Summary
Default Configuration Value
fiftyone/core/config.py
Changed plugins_cache_enabled default from False to True

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A cache now springs to life by default,
No more waiting, no more halt,
Plugins dance with swifter grace,
True becomes the plugins' pace!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat(plugins): enable caching by default" clearly and concisely summarizes the main change in the changeset. It directly aligns with the code modification shown in the summary, where the plugins_cache_enabled default in FiftyOneConfig is changed from False to True. The title uses conventional commit format, is specific about the feature area (plugins), and avoids vague language. It is both descriptive enough for teammates to understand the primary change and appropriately focused without attempting to cover every detail.
Description Check ✅ Passed The pull request description follows the required template structure and includes all essential sections: a clear explanation of proposed changes (enabling plugin cache by default), testing information (tested in fiftyone-teams), and complete release notes with user-facing impact and affected areas clearly marked. The description is not vague or generic; it provides specific details about the change's purpose and guidance for plugin developers on how to maintain hot-reload support if needed. All required template sections are present and appropriately filled out.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ritch/default-plugin-cache

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09ea529 and 51e4c16.

📒 Files selected for processing (1)
  • fiftyone/core/config.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test-windows / test-python (windows-latest, 3.12)
  • GitHub Check: test-windows / test-python (windows-latest, 3.10)
  • GitHub Check: test-windows / test-python (windows-latest, 3.9)
  • GitHub Check: test-windows / test-python (windows-latest, 3.11)
🔇 Additional comments (1)
fiftyone/core/config.py (1)

117-122: LGTM! Behavioral change is well-documented.

The default value change is correct and aligns with the PR objectives. This enables plugin caching by default for improved performance while maintaining the ability to disable it via the FIFTYONE_PLUGINS_CACHE_ENABLED environment variable or configuration file for users who need hot reload support.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants