Skip to content

chore: Use ESLint v9 in development env #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jul 1, 2025

This PR will change the development environment to use ESLint v9.

After looking into the documentation build errors in #2770, I found that a lot of changes are needed.
I want to address those issues first with this PR.

Also, some tests were failing for the script-indent rule when using typescript-eslint v8, so I fixed those as well.

Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: 6e393d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi marked this pull request as draft July 1, 2025 06:13
@ota-meshi ota-meshi marked this pull request as ready for review July 1, 2025 07:04
@ota-meshi
Copy link
Member Author

@2nofa11 Once this PR is merged, please rebase your PR 🙏

@ota-meshi ota-meshi requested a review from FloEdelmann July 1, 2025 07:07
@ota-meshi ota-meshi requested a review from waynzh July 1, 2025 07:11
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you! Apart from two questions (which don't necessarily need to be resolved in context of this PR), this looks good to me.

I think this PR fixes #2756, right? So maybe @2nofa11 you want to have a look, too?

ota-meshi and others added 2 commits July 1, 2025 17:06
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FloEdelmann FloEdelmann linked an issue Jul 1, 2025 that may be closed by this pull request
4 tasks
Copy link

@2nofa11 2nofa11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you! Apart from two questions (which don't necessarily need to be resolved in context of this PR), this looks good to me.

I think this PR fixes #2756, right? So maybe @2nofa11 you want to have a look, too?

I’d love to take a look!
I’m still getting up to speed with the codebase, so I might have some beginner-level questions 😭

@ota-meshi ota-meshi requested review from 2nofa11 and FloEdelmann July 1, 2025 13:02
Copy link

@2nofa11 2nofa11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💯

Comment on lines +62 to +67
"@typescript-eslint/parser": "^7.0.0 || ^8.0.0"
},
"peerDependenciesMeta": {
"@typescript-eslint/parser": {
"optional": true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add another changeset (with a minor version update) explaining this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the changeset 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants