fix(windows): prevent Center() from stealing focus when StartHidden:true#5249
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
fix(windows): prevent Center() from stealing focus when StartHidden:true#5249leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
…s true When StartHidden:true is set, the Center() method's SetWindowPos call would activate the window and steal focus from the foreground application. Adding SWP_NOACTIVATE to the flags prevents this behavior. Fixes #4882
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4882
When a Wails v2 app is started with
StartHidden: trueon Windows, theCenter()method callsSetWindowPoswithHWND_TOPbut without theSWP_NOACTIVATEflag. This causes the window to be activated (stealing focus from the foreground application) even though it should remain hidden.Changes
SWP_NOACTIVATEflag to theSetWindowPoscall inForm.Center()(v2/internal/frontend/desktop/windows/winc/form.go:171)window.go:248whereSWP_NOACTIVATEis already used for positioning operationsTesting
v2/test/4882/center_noactivate_test.goverifying the flag combination