Test different scenarios with subresource Link headers - #33167
Open
noamr wants to merge 10 commits into
Open
Conversation
This was referenced Mar 13, 2022
noamr
force-pushed
the
preload-subresource
branch
from
April 17, 2022 10:53
bc844bd to
6adaf4b
Compare
yoavweiss
reviewed
Apr 20, 2022
| promise_test(async t => { | ||
| const style = {as: 'style', href: '/preload/resources/dummy-preloads-subresource.css', type: 'text/css'}; | ||
| const finalSubresource = {href: `/fonts/CanvasTest.ttf?uid=${token()}`, type: 'font/ttf', as: 'font'}; | ||
| const style2 =; |
yoavweiss
approved these changes
May 9, 2022
yoavweiss
left a comment
yoavweiss
left a comment
Contributor
There was a problem hiding this comment.
LGTM % question about expanding converage (either here or elsewhere)
| test_preload_subresource('script', 'font', true); | ||
| test_preload_subresource('script', 'image', true); | ||
| test_preload_subresource('script', 'script', true); | ||
| test_preload_subresource('script', 'fetch', true); |
Contributor
There was a problem hiding this comment.
Should we also test that e.g. images can't preload content? Or should that be another test?
noamr
enabled auto-merge (squash)
May 9, 2022 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.