fix: Improve editor selection and project tag contrast - #6302
Open
kof wants to merge 9 commits into
Open
Conversation
kof
commented
Sep 1, 2026
kof
commented
Sep 1, 2026
kof
commented
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6301
Summary
Technical choices
selectionBackgroundcontrol-state export unchanged at its original 12% light / 20% dark accent blend.--background-text-selectionand--foreground-on-text-selectiontokens exclusively for selected text.::selectionCSS hooks; no selection tracking or editor-state logic is added.Todo
Verification
pnpm --filter @webstudio-is/design-system test— 227 tests passed, including the control/text separation regression, Navigator tree interaction, default-palette comparisons, and the full supported-theme contrast sweeppnpm --filter @webstudio-is/design-system typecheckpnpm --filter @webstudio-is/builder exec vitest run app/shared/code-editor-base.browser.test.tsx --project app-browser-sharedpnpm --filter @webstudio-is/builder exec vitest run app/dashboard/projects/project-card.browser.test.tsx --project app-browser-canvas-dashboardpnpm --filter @webstudio-is/builder typecheckoxlint, formatting, andgit diff --check