Fire <link rel=preload> error events only for network errors - #7799
Merged
domenic merged 2 commits intoApr 25, 2022
Merged
Conversation
domenic
approved these changes
Apr 12, 2022
domenic
left a comment
domenic
left a comment
Member
There was a problem hiding this comment.
Editorially LGTM, and seems like a reasonable first step. Please ping the thread when you have moved this out of draft state and filled out the template with implementer interest/bugs/tests.
Contributor
Author
|
Updated the PR according to #1142 (comment). |
hiroshige-g
force-pushed
the
FirePreloadErrorEventOnlyOnNetworkError
branch
from
April 18, 2022 20:43
f39799a to
445e391
Compare
hiroshige-g
marked this pull request as ready for review
April 18, 2022 20:43
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 18, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9
Contributor
Author
|
cc/ @noamr @annevk @yoavweiss |
Member
|
My read of #1142 (comment) and following comments is that we have both Gecko and Blink supportive of this spec change. (But, we have you from Blink saying that we won't be able to prioritize this work in the near future.) So I think we have implementer interest, and this is OK to merge as soon as we file browser bugs. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 21, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 21, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9
Contributor
Author
|
Filed browser bugs. Feel free to update e.g. the implementor interest section, the inline note in the spec diff, etc. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 25, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 26, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 26, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963}
3 tasks
past
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 27, 2022
Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963} Co-authored-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Apr 27, 2022
…ests#33382) Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963} Co-authored-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 16, 2022
…rs/non-errors, a=testonly Automatic update from web-platform-tests [WPT] link rel=preload with various errors/non-errors (#33382) Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963} Co-authored-by: Hiroshige Hayashizaki <hiroshige@chromium.org> -- wpt-commits: 55da5e1ca21ef62bd78d29034edbb112a5403384 wpt-pr: 33382
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 25, 2022
…rs/non-errors, a=testonly Automatic update from web-platform-tests [WPT] link rel=preload with various errors/non-errors (#33382) Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963} Co-authored-by: Hiroshige Hayashizaki <hiroshige@chromium.org> -- wpt-commits: 55da5e1ca21ef62bd78d29034edbb112a5403384 wpt-pr: 33382
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…rs/non-errors, a=testonly Automatic update from web-platform-tests [WPT] link rel=preload with various errors/non-errors (#33382) Regression test for - whatwg/html#7799 - https://crbug.com/1305317 Bug: 1305317, 1318623, 1318614, 1318618 Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#995963} Co-authored-by: Hiroshige Hayashizaki <hiroshige@chromium.org> -- wpt-commits: 55da5e1ca21ef62bd78d29034edbb112a5403384 wpt-pr: 33382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #1142.
We have a consensus on the spec dicsussion #1142 about events on
<link rel="preload">, but are not yet sure about the feasibility of implementation/behavior changes and don't have sufficient bandwidth and motivations.This PR writes down the spec-side consensus, while leaving implementation changes as a future work.
Anyway the spec before this PR is more inconsistent with the browsers' behavior.
(See WHATWG Working Mode: Changes for more details.)
/links.html ( diff )