Add WLED_AUTOSEGMENTS compile flag#4183
Merged
Conversation
Contributor
|
If you don't mind I think WLED_OUTPUT_SEGMENTS or WLED_OUTPUT_AUTOSEGMENTS or WLED_CREATE_AUTOSEGMENTS or perhaps just WLED_AUTOSEGMENTS would be more appropriate. |
Contributor
Author
Sure, I like 2nd and 4th the most but your call. |
Contributor
|
I like the simplicity of the last one too. |
blazoncek
approved these changes
Oct 7, 2024
Contributor
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
Approved from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flag to enable setting "Make a segment for each output" at compile.