Skip to content

palette effect overflow fix#4435

Merged
netmindz merged 1 commit intowled:mainfrom
TripleWhy:TripleWhy/issue4425
Jan 9, 2025
Merged

palette effect overflow fix#4435
netmindz merged 1 commit intowled:mainfrom
TripleWhy:TripleWhy/issue4425

Conversation

@TripleWhy
Copy link
Contributor

@TripleWhy TripleWhy commented Dec 27, 2024

I belive this fixes #4425
@TripleWhy TripleWhy mentioned this pull request Dec 27, 2024
Closed
1 task
@TripleWhy
Copy link
Contributor Author

TripleWhy commented Dec 27, 2024

Note: this does replace some more 32 bit multiplications with slightly more expensive 64 bit multiplications.
@blazoncek
Copy link
Contributor

blazoncek commented Dec 27, 2024

Tested and works.
@netmindz netmindz requested a review from DedeHai December 28, 2024 11:02
softhack007
softhack007 reviewed Dec 28, 2024
View reviewed changes
DedeHai
DedeHai approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@DedeHai DedeHai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple fix, approved.
@DedeHai DedeHai added this to the 0.15.1 candidate milestone Dec 29, 2024
@netmindz netmindz merged commit 709aeff into wled:main Jan 9, 2025
@netmindz netmindz added the bug label Jan 16, 2025
@netmindz netmindz mentioned this pull request May 26, 2025
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug

5 participants

@TripleWhy @blazoncek @DedeHai @softhack007 @netmindz