Introduce actionlint job for linting GitHub Actions workflows

[tfrommen]

This is a suggestion to address #84, using the reusable lint-workflows workflow, which under the hood is based on actionlint.

I kept the workflow trigger the same as for code quality.

[swissspidy]

Thanks for the PR, @tfrommen!

I don't think we'd want to use inpsyde/reusable-workflows/.github/workflows/lint-workflows.yml@main here, but either add those two steps directly to the repo or use the suggested steps from the projects' example (with problem matchers).

Also, if we move this to reusable-code-quality.yml, then we can automatically use this workflow here and in all other repos.

[tfrommen]

Hi @swissspidy, happy to change things. What should it be?

[swissspidy]

After sleeping on it, let's go with the suggested integration as per the project's examples, and do that in reusable-code-quality.yml

[tfrommen]

@swissspidy done. I added the shellcheck integration, considering that there are some bash/shell scripts included in this repository already, and I assume more in others.

[swissspidy]

Lets' try this out

[jrfnl]

I added the shellcheck integration, considering that there are some bash/shell scripts included in this repository already, and I assume more in others.

I get the impression that shellcheck is now disabled instead... ?

From actionlint -h:

Flags:
  -shellcheck string
        Command name or file path of "shellcheck" external command. If empty, shellcheck integration will be disabled (default "shellcheck")

[jrfnl]

Suggestion:

        if: ${{ github.event_name == 'pull_request' }}