Add deprecation hint in wp language core activate's docblock#125
Merged
danielbachhuber merged 3 commits intowp-cli:mainfrom Aug 27, 2023
Merged
Conversation
swissspidy
added
the
command:language-core-activate
danielbachhuber
requested changes
Aug 27, 2023
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the PR, @Pathan-Amaankhan !
src/Core_Language_Command.php
Outdated
|
|
||
| /** | ||
| * Activates a given language. | ||
| * Activates a given language. (Deprecated: use wp site switch-language instead) |
Member
There was a problem hiding this comment.
Can we put this on a new line, and make it similar to the deprecation notice for wp scaffold block? https://github.com/wp-cli/scaffold-command/blob/594f0b47a2af6a19664f0f4717998b2cf5cb3ed7/src/Scaffold_Command.php#L205-L208
Contributor
Author
There was a problem hiding this comment.
Sure! On it 👍.
Contributor
Author
There was a problem hiding this comment.
Hello @danielbachhuber,
Have updated the doc-comment as suggested.
Please do let me know if further changes are required 😃.
cc: @swissspidy
Member
There was a problem hiding this comment.
@Pathan-Amaankhan Thanks! I made one more minor tweak eeb97ff
danielbachhuber
approved these changes
Aug 27, 2023
danielbachhuber
changed the title
wp language core activate's docblock [Main]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wp language core activate's docblock & Readme.md file as suggested in this comment.Screenshots of output
Command:
wp language core activate --helpBefore
Synopsis text:
After
Synopsis text:
Fixes/Covers
wp language core activatehelp text #94