Skip to content

http_client: Fix Codex ACP install robustness by staging downloads#45428

Merged
ConradIrwin merged 3 commits intozed-industries:mainfrom
cppcoffee:agent-download
Feb 23, 2026
Merged

http_client: Fix Codex ACP install robustness by staging downloads#45428
ConradIrwin merged 3 commits intozed-industries:mainfrom
cppcoffee:agent-download

Conversation

@cppcoffee
Copy link
Copy Markdown
Contributor

Release Notes:

  • Improved Codex ACP install robustness by staging downloads
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Dec 20, 2025
@github-actions github-actions Bot added the community champion Issues filed by our amazing community champions! 🫶 label Dec 20, 2025
@cppcoffee cppcoffee marked this pull request as draft December 20, 2025 05:58
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
@cppcoffee cppcoffee marked this pull request as ready for review December 20, 2025 13:54
@cppcoffee
Copy link
Copy Markdown
Contributor Author

cppcoffee commented Dec 20, 2025

http_client/project: Make GitHub binary installs atomic via staging

  • Download/extract GitHub release assets into a temporary staging path next to the destination, then rename into place on success.
  • Clean up staging files/dirs on extraction or rename failure to avoid leaving partial installs behind.
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
@SomeoneToIgnore SomeoneToIgnore added area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features and removed community champion Issues filed by our amazing community champions! 🫶 labels Jan 5, 2026
@ConradIrwin ConradIrwin merged commit c2504ad into zed-industries:main Feb 23, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from Community PRs to Done in Quality Week – December 2025 Feb 23, 2026
@ConradIrwin
Copy link
Copy Markdown
Member

Thanks for this, and sorry for the extremely long response time on our side.

Anthony-Eid pushed a commit to bobbymannino/zed that referenced this pull request Feb 25, 2026
…ed-industries#45428)

Release Notes:

- Improved Codex ACP install robustness by staging downloads

---------

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
@cppcoffee cppcoffee deleted the agent-download branch February 25, 2026 13:53
tahayvr pushed a commit to tahayvr/zed that referenced this pull request Mar 4, 2026
…ed-industries#45428)

Release Notes:

- Improved Codex ACP install robustness by staging downloads

---------

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
@Veykril
Copy link
Copy Markdown
Member

Veykril commented Mar 14, 2026

I think this broke updating github based lsps (on Windows at least)

2026-03-14T12:27:10+01:00 INFO [language] failed to fetch newest version of language server LanguageServerName("rust-analyzer"). error: renaming "C:\Users\lukas\AppData\Local\Zed\languages\rust-analyzer\.tmp-github-download-XOJLvN" to "C:\Users\lukas\AppData\Local\Zed\languages\rust-analyzer\rust-analyzer-nightly"

Caused by:
The directory is not empty. (os error 145), falling back to using "C:\Users\lukas\AppData\Local\Zed\languages\rust-analyzer\rust-analyzer-nightly\rust-analyzer.exe"

Veykril added a commit that referenced this pull request Mar 14, 2026
…sts (#51548)

cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
github-actions Bot pushed a commit that referenced this pull request Mar 14, 2026
…sts (#51548)

cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
github-actions Bot pushed a commit that referenced this pull request Mar 14, 2026
…sts (#51548)

cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
zed-zippy Bot added a commit that referenced this pull request Mar 14, 2026
…sts (#51548) (cherry-pick to stable) (#51557)

Cherry-pick of #51548 to stable

----
cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy Bot added a commit that referenced this pull request Mar 14, 2026
…sts (#51548) (cherry-pick to preview) (#51556)

Cherry-pick of #51548 to preview

----
cc
#45428 (comment)

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Co-authored-by: Lukas Wirth <lukas@zed.dev>
tommyming pushed a commit to tommyming/zed that referenced this pull request Mar 15, 2026
piper-of-dawn pushed a commit to piper-of-dawn/zed that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement

5 participants