lsp: Add clangd readonly token modifier to semantic token rules to highlight constant variables as constant#49065
Merged
Veykril merged 1 commit intozed-industries:mainfrom Mar 16, 2026
Conversation
cla-bot
Bot
added
the
cla-signed
maxdeviant
changed the title
Contributor
Author
|
Do you have any plan to add language specific semantic_tokens.json in the future? @Veykril Btw, thanks for the incredible work. |
Member
|
Sorry for the late reply, for builtin languages we already have that, you can take a look at how rust does it, it has its own json rules file. So we can do the same clangd here |
Contributor
Author
I changed the code to add this rule to c++ semantic rules file. |
ozacod
force-pushed
the
feat/clangd-readonly
branch
from
9829e35 to
83059af
Compare
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…ghlight constant variables as constant (zed-industries#49065) Clangd uses the "readonly" token modifier instead of "constant". Therefore, "readonly" should be mapped to highlight constant variables as constants. Before: <img width="706" height="48" alt="before" src="https://github.com/user-attachments/assets/8cc2a310-7825-490b-b868-58ea231612fa" /> After: <img width="762" height="46" alt="after" src="https://github.com/user-attachments/assets/e271d4cd-cc59-45f9-a8b4-2885857915db" /> - [x] Code Reviewed - [x] Manual QA Release Notes: - Added clangd readonly token modifier to semantic token rules to highlight constant variables as constant. Co-authored-by: ozacod <ozacod@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clangd uses the "readonly" token modifier instead of "constant". Therefore, "readonly" should be mapped to highlight constant variables as constants.
Before:
After:
Release Notes: