editor: Fix breadcrumb syntax colors not updating when theme changes#53185
Merged
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom Apr 11, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-codeowner-coordinator
Bot
requested review from
a team,
as-cii and
dinocosta
and removed request for
a team
SomeoneToIgnore
requested changes
Apr 5, 2026
Contributor
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you, please add a test for this to ensure it does not regress.
https://github.com/zed-industries/zed/blob/9a8de58ae5b44bbef3961c841cb6955181313bf7/crates/editor/src/editor.rs#L25825 should help with this, and the test can be set up similar to how semantic tokens are tested.
Contributor
Author
|
Hey! Sorry could not get to it during the week. I added the test. Please let me know if this is what you had in mind. I checked that it passes, and that without the fix, it fails. |
SomeoneToIgnore
approved these changes
Apr 11, 2026
Contributor
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
No worries at all, and thank you for the test, that looks exactly what's needed.
Contributor
|
Ready to merge it once the CI style issue is fixed. |
Contributor
Author
|
Perfect. Tried to fix that as well. |
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
For testing, see the before:
And see the after:
Closes #53183
Release Notes: