project_panel: Always open panel on pane's reveal in project panel#53539
Merged
project_panel: Always open panel on pane's reveal in project panel#53539
Conversation
Update the way `pane::RevealInProjectPanel` is handled to ensure that, regardless of whether the file belongs to any open project, the project panel is always activated and focused. This refactor is a result of some internal feedback after changing its handling so as to show a notification stating that the item that the user was trying to reveal didn't belong to an open project. We feel users are probably already used to relying on `cmd-shift-e` (on macOS), in pretty much every context, in order to open the project panel, and so having situations where it doesn't actually happen seems like a bad user experience.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
dinocosta
changed the title
3 tasks
maxbrunsfeld
approved these changes
Apr 13, 2026
Contributor
|
Does this need to be cherry-picked to stable? The stable release notes mention this PR, but it isn't part of the release. Ideally, this should've landed in the same release as #51246. |
Member
Author
Definitely! Thank you for calling that out, I had a note to cherry pick to preview right after merging but somehow forgot to do that 🤦 Will coordinate with the team to see if it makes sense to do a patch release including this, and likely other changes. Thanks! |
Contributor
|
/cherry-pick stable |
Contributor
|
/cherry-pick preview |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
…53539) Update the way `pane::RevealInProjectPanel` is handled to ensure that, regardless of whether the file belongs to any open project, the project panel is always activated and focused. This refactor is a result of some internal feedback after changing its handling so as to show a notification stating that the item that the user was trying to reveal didn't belong to an open project – #51246 . We feel users are probably already used to relying on `cmd-shift-e` (on macOS), in pretty much every context, in order to open the project panel, and so having situations where it doesn't actually happen seems like a bad user experience. Relates to #23967 Release Notes: - Improved `pane: reveal in project panel` to open the project panel, even if working with an unsaved buffer.
Contributor
|
🍒💥 Cherry-pick did not succeed |
18 tasks
eholk
added a commit
that referenced
this pull request
Apr 16, 2026
We're doing another preview release today to get our latest parallel agents features out there. This PR is a rollup of all the changes we need to cherry pick. - [x] 7a26e48 from #54081 - [x] #54066 - [x] #53992 - [x] #54079 - [x] #54057 - [x] #54056 - [x] #54052 - [x] #53999 - [x] #54009 - [x] #53539 (already cherry picked as 25e02cb) - [x] #54070 - [x] #54053 - fix `run_tests.yml`: 67e92b5 - [x] #53979 - [x] #53884 - [x] #54067 - [x] #54014 (already on branch) - [x] #54030 (already on branch) - [x] #54094 Release Notes: - N/A --------- Co-authored-by: Lukas Wirth <me@lukaswirth.dev> Co-authored-by: Bennet Bo Fenner <bennet@zed.dev> Co-authored-by: Nathan Sobo <nathan@zed.dev> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Neel <neel@zed.dev> Co-authored-by: Richard Feldman <richard@zed.dev>
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…ed-industries#53539) Update the way `pane::RevealInProjectPanel` is handled to ensure that, regardless of whether the file belongs to any open project, the project panel is always activated and focused. This refactor is a result of some internal feedback after changing its handling so as to show a notification stating that the item that the user was trying to reveal didn't belong to an open project – zed-industries#51246 . We feel users are probably already used to relying on `cmd-shift-e` (on macOS), in pretty much every context, in order to open the project panel, and so having situations where it doesn't actually happen seems like a bad user experience. Relates to zed-industries#23967 Release Notes: - Improved `pane: reveal in project panel` to open the project panel, even if working with an unsaved buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the way
pane::RevealInProjectPanelis handled to ensure that, regardless of whether the file belongs to any open project, the project panel is always activated and focused.This refactor is a result of some internal feedback after changing its handling so as to show a notification stating that the item that the user was trying to reveal didn't belong to an open project – #51246 .
We feel users are probably already used to relying on
cmd-shift-e(on macOS), in pretty much every context, in order to open the project panel, and so having situations where it doesn't actually happen seems like a bad user experience.Self-Review Checklist:
Relates to #23967
Release Notes:
pane: reveal in project panelto open the project panel, even if working with an unsaved buffer.