Skip to content

Fix info colors used for hint diagnostics#54046

Merged
Veykril merged 2 commits intozed-industries:mainfrom
vonEdfa:fix-info-color-for-hint-diagnostics
Apr 20, 2026
Merged

Fix info colors used for hint diagnostics#54046
Veykril merged 2 commits intozed-industries:mainfrom
vonEdfa:fix-info-color-for-hint-diagnostics

Conversation

@vonEdfa
Copy link
Copy Markdown
Contributor

@vonEdfa vonEdfa commented Apr 16, 2026

Super small update changing two instances where DiagnosticSeverity::HINT was set to use the color for "info".

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #45637

Release Notes:

  • Fixed various instances of hint level diagnostics using the color designated for info
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 16, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Apr 16, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, cameron1024, dinocosta and eholk and removed request for a team April 16, 2026 08:03
@vonEdfa
Copy link
Copy Markdown
Contributor Author

vonEdfa commented Apr 16, 2026

I left the test checkbox unchecked as I could not find any existing tests covering the lines changed and since this is my first contribution and I was unsure about the preferred practice for these instances. I also honestly wanted to keep the changes simple and small.

If you wish me to add tests for these lines let me know and I'll look into it. Otherwise we can check that box too. :)

Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) April 20, 2026 08:47
@Veykril Veykril merged commit 9e2c493 into zed-industries:main Apr 20, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

4 participants