Skip to content

Use dockerfile build args correctly, respect context path, fix image aliasing#54210

Merged
KyleBarton merged 1 commit intomainfrom
fix_build_context_and_args_for_devcontainer_dockerfiles
Apr 20, 2026
Merged

Use dockerfile build args correctly, respect context path, fix image aliasing#54210
KyleBarton merged 1 commit intomainfrom
fix_build_context_and_args_for_devcontainer_dockerfiles

Conversation

@KyleBarton
Copy link
Copy Markdown
Collaborator

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #54193

Additionally, respects cacheFrom and options args defined in devcontainer.json's build object. Also, addresses a bug which was hiding these problems by overriding the primary build target with aliasing.

Release Notes:

  • Fixed an image aliasing but, respect build context and build args in dev containers
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 17, 2026
@SomeoneToIgnore SomeoneToIgnore self-assigned this Apr 19, 2026
@KyleBarton KyleBarton merged commit 17026b1 into main Apr 20, 2026
33 checks passed
@KyleBarton KyleBarton deleted the fix_build_context_and_args_for_devcontainer_dockerfiles branch April 20, 2026 15:38
antont added a commit to antont/zed that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants