Skip to content

recent_projects: Fix unaligned keybinding labels in quick-switch menu#54325

Merged
danilo-leal merged 4 commits intozed-industries:mainfrom
galuis116:fix/recent-projects-shortcut-alignment
Apr 20, 2026
Merged

recent_projects: Fix unaligned keybinding labels in quick-switch menu#54325
danilo-leal merged 4 commits intozed-industries:mainfrom
galuis116:fix/recent-projects-shortcut-alignment

Conversation

@galuis116
Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #54324

Release Notes:

  • Fixed shortcut label alignment in the Recent Projects quick-switch footer by rendering action rows with a consistent two-column layout (label left, keybinding right) for “Add Local Folders” and “Add Remote Folder”.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 20, 2026
@maxdeviant maxdeviant changed the title fix:Bug: Shortcut labels are not aligned in recent projects quick-switch menu Apr 20, 2026
Copy link
Copy Markdown
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the ButtonLike component like I did in your last PR?

@galuis116
Copy link
Copy Markdown
Contributor Author

I will check your last PR relative to ButtonLike component and commit.

@galuis116
Copy link
Copy Markdown
Contributor Author

I have updatede as what you mentioned and pushed commit.

.w_full()
.gap_1()
.justify_between()
.items_center()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.items_center()

You can take off these item_center methods as they're included already in h_flex.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I have just updated according to your feedback and pushed commit.

@galuis116
Copy link
Copy Markdown
Contributor Author

I have updated according to your feedback and pushed commit.

@galuis116
Copy link
Copy Markdown
Contributor Author

It seems that it is ready to merge.

@galuis116
Copy link
Copy Markdown
Contributor Author

galuis116 commented Apr 20, 2026

I am waiting for this to be merged as all passed and verified.
image

@galuis116 galuis116 requested a review from danilo-leal April 20, 2026 17:39
@galuis116
Copy link
Copy Markdown
Contributor Author

Hellow @danilo-leal, I am waiting for you to merge this pull request.

Copy link
Copy Markdown
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danilo-leal danilo-leal merged commit f37df7b into zed-industries:main Apr 20, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants