Skip to content

agent_ui: Fix inconsistent Rules keybinding in Toggle Agent Menu#54420

Merged
danilo-leal merged 3 commits intozed-industries:mainfrom
galuis116:fix/agent-menu-rules-shortcut-context
Apr 22, 2026
Merged

agent_ui: Fix inconsistent Rules keybinding in Toggle Agent Menu#54420
danilo-leal merged 3 commits intozed-industries:mainfrom
galuis116:fix/agent-menu-rules-shortcut-context

Conversation

@galuis116
Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #54419

Release Notes:

  • Fixed Agent menu shortcut context handling so Alt-Shift-L consistently resolves to Rules (and displays correctly) when the Toggle Agent Menu is open, while preserving existing global/context-specific shortcuts such as Language Servers and onboarding bindings outside Agent menu context.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 21, 2026
@maxdeviant maxdeviant changed the title fix:Bug: shortcut for Rules is inconsistent in Toggle Agent Menu Apr 21, 2026
@galuis116
Copy link
Copy Markdown
Contributor Author

Hello @maxdeviant, I am waiting to check this pull request and merge.

Copy link
Copy Markdown
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed a fix simplifying it; having the menu take the focus is already enough to make the Rules keybinding not get overridden by whatever else uses the same binding.

@danilo-leal danilo-leal merged commit 80ab748 into zed-industries:main Apr 22, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants