feat(discov): expose etcd AutoSyncInterval in EtcdConf - #5676
Open
Vierblatt wants to merge 4 commits into
Open
Conversation
Allows users to configure the etcd client auto sync interval via EtcdConf.AutoSyncInterval. When set (>0), it overrides the default at etcd client level via per-cluster registration, matching the existing pattern of RegisterAccount and RegisterTLS. Fixes zeromicro#5619
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
AutoSyncIntervalfield toEtcdConf, allowing users to configure the etcd client auto sync interval. When set (>0), it overrides the default via per-cluster registration, matching the existing pattern ofRegisterAccountandRegisterTLS.Motivation
Fixes #5619. go-zero's etcd discovery creates the etcd client internally, so users cannot control
AutoSyncIntervaltoday. This matters when applications should keep using the configuredEtcd.Hosts, such as an etcd LB / VIP / proxy (related: #5005).Test plan