fix(admin): add retries for GroupCoordinator errors #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dnwe
commented
Jan 5, 2025
dnwe
commented
- retry admin operations that rely on talking to the group coordinator for a given ID if the coordinator has changed from the cached value, or is not available
- also fixup controller retry in ElectLeaders to use the err from response rather than sendAndReceive
- also rename isErrNotController to isRetriableControllerError for consistency
puellanivis
reviewed
Jan 5, 2025
dnwe
force-pushed
the
dnwe/admin
branch
2 times, most recently
from
0c7dafc to
718ce09
Compare
puellanivis
reviewed
Jan 7, 2025
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
- retry admin operations that rely on talking to the group coordinator for a given ID if the coordinator has changed from the cached value, or is not available - also fixup controller retry in ElectLeaders to use the err from response rather than sendAndReceive - also rename isErrNotController to isRetriableControllerError for consistency Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Use a named return for the defer func to inspect to avoid subtle bugs Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.