fix(arrow/array): fix panic in dictionary builders - #517
Merged
Conversation
lidavidm
approved these changes
Sep 23, 2025
amoeba
approved these changes
Sep 24, 2025
amoeba
left a comment
amoeba
left a comment
Member
There was a problem hiding this comment.
+1
It looks like the switch handles all the types it needs as far as I can tell. CI failure looks unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The underlying hash table is in terms of primitive types (int64/int32/int16, etc.) not the top-level types (arrow.Duration, arrow.Timestamp, etc.) which results in a panic mismatch when appending values.
fixes #516
What changes are included in this PR?
Checking and validating the type when appendValue is called to ensure correct type coercion.
Are these changes tested?
A unit test is added in this change.
Are there any user-facing changes?
A case that previously caused a panic will now be successful.