refactor(arrow): last increment of the Record -> RecordBatch migration - #522
Merged
zeroshade merged 3 commits intoOct 6, 2025
Merged
Conversation
zeroshade
reviewed
Oct 6, 2025
zeroshade
approved these changes
Oct 6, 2025
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Looks good generally, just one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Rename the Record interface to RecordBatch for clarity, since Record commonly means a single row but this type represents a batch of rows.
What changes are included in this PR?
The rest of the code is now changed to use the RecordBatch method and updated interface.
Are these changes tested?
Yes. All affected packages build successfully and core tests pass.
Are there any user-facing changes?
No user facing API changes.
Closes #457