Skip to content

doc(parquet): document arrow parquet mappings - #561

Merged
zeroshade merged 3 commits into
apache:mainfrom
amoeba:docs/document-arrow-parquet-mappings
Nov 8, 2025
Merged

doc(parquet): document arrow parquet mappings#561
zeroshade merged 3 commits into
apache:mainfrom
amoeba:docs/document-arrow-parquet-mappings

Conversation

@amoeba

@amoeba amoeba commented Nov 7, 2025

Copy link
Copy Markdown
Member

Rationale for this change

Documents the Arrow to Parquet type conversions and documents which types have no conversion. Closes #403

What changes are included in this PR?

I'm sneaking this into the doc.go file for the parquet package so this PR just adds text tehre.

Are these changes tested?

Visually and partially with some unit tests (not included).

Are there any user-facing changes?

No

@amoeba
amoeba requested a review from zeroshade as a code owner November 7, 2025 01:27
@amoeba amoeba changed the title Docs/document arrow parquet mappings Nov 7, 2025
@amoeba amoeba changed the title doc(parquet): document arrow parquet mappings Nov 7, 2025
@amoeba amoeba changed the title doc(parquet/pqarrow): document arrow parquet mappings Nov 7, 2025

@zeroshade zeroshade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Comment thread parquet/doc.go
// DURATION, INTERVAL_MONTHS, INTERVAL_DAY_TIME, INTERVAL_MONTH_DAY_NANO
// SPARSE_UNION, DENSE_UNION
// STRING_VIEW, BINARY_VIEW, LIST_VIEW, LARGE_LIST_VIEW
// LARGE_LIST, RUN_END_ENCODED

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really error on LargeList here? I should probably fix that then :(

I need to get around to updating this to properly handle the view types.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. This test passes,

diff --git a/parquet/pqarrow/schema_test.go b/parquet/pqarrow/schema_test.go
index 6f5d14c7..f9817492 100644
--- a/parquet/pqarrow/schema_test.go
+++ b/parquet/pqarrow/schema_test.go
@@ -439,6 +439,7 @@ func TestUnsupportedTypes(t *testing.T) {
 		{typ: &arrow.MonthDayNanoIntervalType{}},
 		{typ: &arrow.DenseUnionType{}},
 		{typ: &arrow.SparseUnionType{}},
+		{typ: arrow.LargeListOf(arrow.PrimitiveTypes.Int32)},
 	}
 	for _, tc := range unsupportedTypes {
 		t.Run(tc.typ.ID().String(), func(t *testing.T) {
@zeroshade
zeroshade merged commit 3160eef into apache:main Nov 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants