doc(parquet): document arrow parquet mappings - #561
Merged
zeroshade merged 3 commits intoNov 8, 2025
Conversation
zeroshade
approved these changes
Nov 7, 2025
| // DURATION, INTERVAL_MONTHS, INTERVAL_DAY_TIME, INTERVAL_MONTH_DAY_NANO | ||
| // SPARSE_UNION, DENSE_UNION | ||
| // STRING_VIEW, BINARY_VIEW, LIST_VIEW, LARGE_LIST_VIEW | ||
| // LARGE_LIST, RUN_END_ENCODED |
Member
There was a problem hiding this comment.
do we really error on LargeList here? I should probably fix that then :(
I need to get around to updating this to properly handle the view types.
Member
Author
There was a problem hiding this comment.
I think so. This test passes,
diff --git a/parquet/pqarrow/schema_test.go b/parquet/pqarrow/schema_test.go
index 6f5d14c7..f9817492 100644
--- a/parquet/pqarrow/schema_test.go
+++ b/parquet/pqarrow/schema_test.go
@@ -439,6 +439,7 @@ func TestUnsupportedTypes(t *testing.T) {
{typ: &arrow.MonthDayNanoIntervalType{}},
{typ: &arrow.DenseUnionType{}},
{typ: &arrow.SparseUnionType{}},
+ {typ: arrow.LargeListOf(arrow.PrimitiveTypes.Int32)},
}
for _, tc := range unsupportedTypes {
t.Run(tc.typ.ID().String(), func(t *testing.T) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Documents the Arrow to Parquet type conversions and documents which types have no conversion. Closes #403
What changes are included in this PR?
I'm sneaking this into the doc.go file for the parquet package so this PR just adds text tehre.
Are these changes tested?
Visually and partially with some unit tests (not included).
Are there any user-facing changes?
No