optimization: schema: use slices.Sort instead of sort.Slice - #564
Merged
Conversation
Shaves off ~1/3rd of the time of Metadata.Equal for me; sort.Slice takes in `any` as the type of the slice, which requires converting the slice to an interface - which itself requires allocating and converting the pointer to the slice header to use as the interface value.
Contributor
Author
|
sort.Strings is just a wrapper for slices.Sort now; as such, drop the other usage of the sort module in schema.go and drop the dependency too |
Contributor
Author
|
I figure I should probably include this as the motivation: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shaves off nearly half of the time of Metadata.Equal for me; sort.Slice takes in
anyas the type of the slice, which requires converting the slice to an interface - which itself requires allocating and converting the pointer to the slice header to use as the interface value.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?