Skip to content

fix(toolbox): fix dataView component does not fit dark mode - #21176

Merged
Ovilia merged 2 commits into
apache:masterfrom
notthistrain:fix-21170
Aug 22, 2025
Merged

fix(toolbox): fix dataView component does not fit dark mode#21176
Ovilia merged 2 commits into
apache:masterfrom
notthistrain:fix-21170

Conversation

@notthistrain

@notthistrain notthistrain commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the DataView component does not fit dark mode.

Fixed issues

Details

Before: What was the problem?

Create an instance of the dark theme, but the style of the dataview is not dark

image

After: How does it behave after the fixing?

The style of dataview follows the theme

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Comment thread src/theme/dark.ts Outdated
@plainheart plainheart added this to the 6.0.1 milestone Aug 11, 2025
@github-actions

github-actions Bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21176@4c3f305

Co-authored-by: Zhongxiang Wang <yhen@all-my-life.cn>
@Ovilia
Ovilia merged commit edbadad into apache:master Aug 22, 2025
2 checks passed
@echarts-bot

echarts-bot Bot commented Aug 22, 2025

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia

Ovilia commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

100pah added a commit that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment