Skip to content

fix(dataZoom): fix wrong position of the dataZoom when the series has only one data point - #21196

Merged
Ovilia merged 2 commits into
apache:masterfrom
alesmit:fix-21195
Sep 16, 2025
Merged

fix(dataZoom): fix wrong position of the dataZoom when the series has only one data point#21196
Ovilia merged 2 commits into
apache:masterfrom
alesmit:fix-21195

Conversation

@alesmit

@alesmit alesmit commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix position of the dataZoom control when the series has only one data point. Please refer to the linked issue for more details.

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).
@plainheart
plainheart requested a review from 100pah August 11, 2025 16:46
@plainheart plainheart linked an issue Aug 11, 2025 that may be closed by this pull request
@github-actions

github-actions Bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21196@369d3b6

@plainheart plainheart changed the title fix(dataZoom): handle NaN rect coords in positionGroup. close #21195 Aug 11, 2025
@plainheart plainheart added this to the 6.0.1 milestone Aug 11, 2025

@Ovilia Ovilia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding test cases according to the wiki

@plainheart plainheart added the PR: regression fix This PR is to fix regression issues label Aug 23, 2025
@alesmit

alesmit commented Aug 30, 2025

Copy link
Copy Markdown
Contributor Author

Added a test case.

@Ovilia
Ovilia merged commit 5139180 into apache:master Sep 16, 2025
2 checks passed
@echarts-bot

echarts-bot Bot commented Sep 16, 2025

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia removed the PR: regression fix This PR is to fix regression issues label Sep 16, 2025
@Ovilia

Ovilia commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment