[wrangler] Apply Email Routing addresses during deploy - #14471
Merged
Conversation
🦋 Changeset detectedLatest commit: 7297d7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
6 times, most recently
from
June 30, 2026 10:51
9c7642b to
4dcf055
Compare
DiogoSantoss
marked this pull request as ready for review
June 30, 2026 10:54
workers-devprod
requested review from
a team and
jamesopstad
and removed request for
a team
June 30, 2026 10:54
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
from
June 30, 2026 10:55
4dcf055 to
83b1eee
Compare
5 tasks
![devin-ai-integration[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
2 times, most recently
from
June 30, 2026 11:20
4aa3de4 to
b030365
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
from
June 30, 2026 14:43
b030365 to
27a3daa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
from
July 3, 2026 14:11
b05ba27 to
7878927
Compare
Contributor
|
Can you merge #14470 now it's approved and then I'll review this one. Thanks. |
emily-shen
previously requested changes
Jul 9, 2026
emily-shen
left a comment
emily-shen
left a comment
Contributor
There was a problem hiding this comment.
changes to the deploy path should go in the deploy-helpers package or else they will not be included in cf
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
2 times, most recently
from
July 15, 2026 09:54
eb12ccd to
a0d1de8
Compare
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ttoino
reviewed
Jul 16, 2026
ttoino
left a comment
ttoino
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one small comment
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
from
July 16, 2026 15:23
f9eed56 to
de9f833
Compare
jamesopstad
approved these changes
Jul 17, 2026
workers-devprod
approved these changes
Jul 17, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
jamesopstad
dismissed
emily-shen’s stale review
July 17, 2026 12:34
Code moved to deploy-helpers package as requested.
added 7 commits
July 17, 2026 13:48
EMAIL-1882: after the Worker uploads, `wrangler deploy` plans the Email Routing changes for the `addresses` config against the new account-level plan endpoint, renders them grouped by zone, prompts once for destructive changes (deletes/takeover conflicts) interactively and hard-fails in non-interactive mode, then applies accepted changes via the per-zone rule endpoints tagged source=wrangler + owner_worker_tag. Stacked on EMAIL-1880.
DiogoSantoss
force-pushed
the
dsantos/EMAIL-1882
branch
from
July 17, 2026 12:48
de9f833 to
7297d7b
Compare
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the Email Routing
addressesconfig duringwrangler deploy.Note
Stacked on #14470 (the
addressesconfig field). Please review #14470 first — until it merges, this PR's diff includes its commit too. The new logic here is inpackages/wrangler/src/email-routing/deploy-addresses.ts+ thedeploy.tshook.After the Worker uploads,
wrangler deployasks the Email Routing API for a plan, renders the changes grouped by zone (+added,~updated,-deleted,!conflict), prompts once for any destructive changes (deletes or takeover conflicts) in interactive mode — and hard-fails in non-interactive/CI mode — then applies the accepted changes through the per-zone rule endpoints, tagging them as owned by the deploying Worker. Purely additive plans apply without a prompt; a partial apply failure leaves the Worker deployed and exits non-zero.wrangler deploy --dry-runis unchanged (validate + print only, no network).Internal tracking: EMAIL-1882 / RM-29262.
🐈