fix(httpUrl): allow underscores in hostname - #6273
Open
deepshekhardas wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5960.
Problem
z.httpUrl()rejects hostnames containing underscores (e.g.,https://julia_artberg.artstation.com/orhttps://exa_mple.com/), even though underscores are commonly used in real-world URLs.Root cause
The
domainregex used byhttpUrl()for hostname validation only allows letters, digits, and hyphens in each label. Underscores (_) are excluded.Fix
Added
_to the allowed character set in the domain regex — both for the start/end of each label ([a-zA-Z0-9_]) and for the middle positions ([a-zA-Z0-9_-]).