Log Fragment name when trying to render a lazy fragment #30372

tom-sherman · 2024-07-18T10:04:48Z

Summary

How did you test this change?

See test.

vercel · 2024-07-18T10:04:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2024 4:47pm

react-sizebot · 2024-07-18T10:12:10Z

Comparing: 163365a...228669e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	+0.35%	499.44 kB	501.17 kB	+0.40%	89.59 kB	89.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	+0.34%	504.26 kB	505.99 kB	+0.39%	90.30 kB	90.66 kB
facebook-www/ReactDOM-prod.classic.js	+0.01%	599.20 kB	599.28 kB	+0.02%	105.80 kB	105.82 kB
facebook-www/ReactDOM-prod.modern.js	+0.37%	573.37 kB	575.47 kB	+0.43%	101.68 kB	102.11 kB
test_utils/ReactAllWarnings.js	Deleted	64.07 kB	0.00 kB	Deleted	15.86 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
facebook-www/ReactART-prod.modern.js	+0.60%	348.84 kB	350.94 kB	+0.75%	59.19 kB	59.63 kB
oss-stable-rc/react-art/cjs/react-art.production.js	+0.59%	292.58 kB	294.30 kB	+0.72%	50.59 kB	50.96 kB
oss-stable-semver/react-art/cjs/react-art.production.js	+0.59%	292.58 kB	294.30 kB	+0.72%	50.59 kB	50.96 kB
oss-stable/react-art/cjs/react-art.production.js	+0.59%	292.62 kB	294.35 kB	+0.72%	50.62 kB	50.98 kB
oss-experimental/react-art/cjs/react-art.production.js	+0.58%	297.27 kB	299.00 kB	+0.70%	51.38 kB	51.74 kB
react-native/implementations/ReactFabric-prod.js	+0.50%	344.76 kB	346.47 kB	+0.63%	60.51 kB	60.90 kB
react-native/implementations/ReactNativeRenderer-prod.js	+0.48%	354.15 kB	355.86 kB	+0.61%	62.17 kB	62.55 kB
react-native/implementations/ReactFabric-profiling.js	+0.46%	371.99 kB	373.70 kB	+0.60%	64.69 kB	65.07 kB
react-native/implementations/ReactNativeRenderer-profiling.js	+0.45%	381.31 kB	383.02 kB	+0.58%	66.43 kB	66.81 kB
facebook-www/ReactDOM-prod.modern.js	+0.37%	573.37 kB	575.47 kB	+0.43%	101.68 kB	102.11 kB
facebook-www/ReactDOM-profiling.modern.js	+0.35%	602.59 kB	604.69 kB	+0.40%	105.94 kB	106.36 kB
oss-stable-rc/react-dom/cjs/react-dom-client.production.js	+0.35%	499.34 kB	501.07 kB	+0.40%	89.57 kB	89.93 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js	+0.35%	499.34 kB	501.07 kB	+0.40%	89.57 kB	89.93 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	+0.35%	499.44 kB	501.17 kB	+0.40%	89.59 kB	89.95 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	+0.34%	504.26 kB	505.99 kB	+0.39%	90.30 kB	90.66 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.profiling.js	+0.32%	532.12 kB	533.85 kB	+0.38%	94.75 kB	95.11 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js	+0.32%	532.12 kB	533.85 kB	+0.38%	94.75 kB	95.11 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js	+0.32%	532.23 kB	533.95 kB	+0.38%	94.77 kB	95.14 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js	+0.32%	537.04 kB	538.77 kB	+0.40%	95.47 kB	95.85 kB
test_utils/ReactAllWarnings.js	Deleted	64.07 kB	0.00 kB	Deleted	15.86 kB	0.00 kB

Generated by 🚫 dangerJS against 228669e

Ammend test

packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js

eps1lon · 2024-07-22T13:32:36Z

packages/react-reconciler/src/ReactFiberBeginWork.js

    }
  }

+  const loggedComponent = Component === REACT_FRAGMENT_TYPE ? '<Fragment>' : Component;


We can use getComponentNameFromType from shared/getComponentNameFromType here instead. That way we also get a better name for all the other types you're not supposed to use.

Suggested change

const loggedComponent = Component === REACT_FRAGMENT_TYPE ? '<Fragment>' : Component;

const loggedComponent = getComponentNameFromType(Component) || String(Component);

Forgot that we use + '' for perf so || (Component + '') it is.

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>

eps1lon

Thanks

eps1lon · 2024-07-23T15:41:05Z

Prettier and lint failing.

tom-sherman · 2024-07-23T16:05:31Z

@eps1lon I chose to ignore the string coercion lint, let me know if that's not ok and I can find a different way forward - probably by introducing a new string coercion check function for components?

eps1lon · 2024-07-23T16:42:02Z

Let's just be simple about it and do what the lint rule asks.

eps1lon · 2024-07-23T16:43:09Z

Seems like common practice though.

tom-sherman · 2024-07-23T16:55:54Z

Let's just be simple about it and do what the lint rule asks.

What solution are you thinking of? The lint rule asks to use a "checkXxxxxStringCoercion" function but none exists for components right now, which is why I suggested creating one.

eps1lon · 2024-07-23T17:00:47Z

What solution are you thinking of?

Just kept the original behavior.

DiffTrain build for commit 9cc0f6e.

DiffTrain build for [9cc0f6e](9cc0f6e)

facebook-github-bot added the CLA Signed label Jul 18, 2024

vercel bot deployed to Preview July 18, 2024 10:07 View deployment

tom-sherman force-pushed the gh-26910 branch from 499fdd7 to 03934db Compare July 18, 2024 10:07

vercel bot deployed to Preview July 18, 2024 10:11 View deployment

Log proper error when trying to render a lazy fragment

e08f2e6

Ammend test

tom-sherman force-pushed the gh-26910 branch from 03934db to e08f2e6 Compare July 18, 2024 12:36

vercel bot deployed to Preview July 18, 2024 12:39 View deployment

eps1lon reviewed Jul 22, 2024

View reviewed changes

tom-sherman and others added 3 commits July 23, 2024 10:05

Use getComponentNameFromType

55ee91c

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>

Remove unused import

88cb77d

Update test

9acb211

vercel bot deployed to Preview July 23, 2024 09:17 View deployment

tom-sherman requested a review from eps1lon July 23, 2024 09:40

eps1lon changed the title ~~Log proper error when trying to render a lazy fragment~~ Jul 23, 2024

eps1lon approved these changes Jul 23, 2024

View reviewed changes

Ignore string coercion lint

bdd623f

vercel bot deployed to Preview July 23, 2024 16:06 View deployment

Keep original behavior if Component isn't a Component

228669e

vercel bot deployed to Preview July 23, 2024 16:47 View deployment

eps1lon approved these changes Jul 23, 2024

View reviewed changes

eps1lon merged commit 9cc0f6e into facebook:main Jul 23, 2024

tom-sherman deleted the gh-26910 branch July 23, 2024 17:06

github-actions bot pushed a commit that referenced this pull request Jul 23, 2024

Log Fragment name when trying to render a lazy fragment (#30372)

8f1a56e

DiffTrain build for commit 9cc0f6e.

github-actions bot pushed a commit that referenced this pull request Jul 23, 2024

Log Fragment name when trying to render a lazy fragment (#30372)

288b7b7

DiffTrain build for [9cc0f6e](9cc0f6e)

felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024

Log Fragment name when trying to render a lazy fragment (facebook#30372)

b497bdd

felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024

Log Fragment name when trying to render a lazy fragment (facebook#30372)

a49df82

felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024

Log Fragment name when trying to render a lazy fragment (facebook#30372)

d1c23b1

felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024

Log Fragment name when trying to render a lazy fragment (facebook#30372)

fcb4867

felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024

Log Fragment name when trying to render a lazy fragment (facebook#30372)

ce903bc

This was referenced Jul 25, 2024

Update React from 6230622a1a-20240610 to 76002254-20240724 vercel/next.js#68149

Merged

Update React from 6230622a1a-20240610 to 3208e73e-20240730 vercel/next.js#68330

Merged

fossabot bot mentioned this pull request Oct 2, 2025

Bump react and @types/react in /web-app franchb/console#14

Open

fossabot bot mentioned this pull request Oct 20, 2025

chore(deps): bump react and @types/react blinklabs-io/after-town-hall#281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Log Fragment name when trying to render a lazy fragment #30372

Log Fragment name when trying to render a lazy fragment #30372

Uh oh!

tom-sherman commented Jul 18, 2024 •

edited

Loading

vercel bot commented Jul 18, 2024 •

edited

Loading

react-sizebot commented Jul 18, 2024 •

edited

Loading

Uh oh!

eps1lon Jul 22, 2024

eps1lon Jul 23, 2024

eps1lon left a comment

eps1lon commented Jul 23, 2024

tom-sherman commented Jul 23, 2024

eps1lon commented Jul 23, 2024

eps1lon commented Jul 23, 2024

tom-sherman commented Jul 23, 2024

eps1lon commented Jul 23, 2024

Labels

4 participants

	const loggedComponent = Component === REACT_FRAGMENT_TYPE ? '<Fragment>' : Component;
	const loggedComponent = getComponentNameFromType(Component) \|\| String(Component);

Log Fragment name when trying to render a lazy fragment #30372

Log Fragment name when trying to render a lazy fragment #30372

Uh oh!

Conversation

tom-sherman commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

vercel bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

react-sizebot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

eps1lon Jul 22, 2024

Choose a reason for hiding this comment

eps1lon Jul 23, 2024

Choose a reason for hiding this comment

eps1lon left a comment

Choose a reason for hiding this comment

eps1lon commented Jul 23, 2024

tom-sherman commented Jul 23, 2024

eps1lon commented Jul 23, 2024

eps1lon commented Jul 23, 2024

tom-sherman commented Jul 23, 2024

eps1lon commented Jul 23, 2024

Labels

4 participants

tom-sherman commented Jul 18, 2024 •

edited

Loading

vercel bot commented Jul 18, 2024 •

edited

Loading

react-sizebot commented Jul 18, 2024 •

edited

Loading