chore(deps): update eslint (major) - #3914
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3914 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 914 914
Lines 3215 3215
Branches 591 574 -17
=======================================
Hits 3178 3178
Misses 33 33
Partials 4 4
🚀 New features to boost your workflow:
|
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e62e85d to
8835be4
Compare
|
IMO we might want to turn this rule off. |
what is "this" rule? |
8835be4 to
73dfa17
Compare
73dfa17 to
5ad2e49
Compare
|
I'll address the lint issues. |
|
Done. I disabled most rules globally, some locally and fixed a few instances. If you want to handle cases differently, feel free to adjust them according to your wishes. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
65.0.1→68.0.0Release Notes
sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)
v68.0.0Compare Source
Breaking
prevent-abbreviationsrule toname-replacements(#3362)af0158dAwesome
Now 300+ rules 🎉
New rules
consistent-conditional-object-spread(#3326)8aa1e0ddefault-export-style(#3364)0015e81no-accidental-bitwise-operator(#3318)af2661eno-array-concat-in-loop(#3350)4a1f65cno-array-front-mutation(#3323)d8302bdno-array-sort-for-min-max(#3351)e4b6666no-boolean-sort-comparator(#3368)3be859cno-chained-comparison(#3310)c29e211no-collection-bracket-access(#3286)6ccd694no-constant-zero-expression(#3311)134eea2no-double-comparison(#3329)ae4d7d7no-duplicate-if-branches(#3346)94b8c3bno-duplicate-logical-operands(#3348)af07fd8no-impossible-length-comparison(#3342)84dfd8bno-invalid-character-comparison(#3333)b2e9191no-loop-iterable-mutation(#3357)b961432no-misrefactored-assignment(#3315)063a798no-nonstandard-builtin-properties(#3337)14cc4dbno-selector-as-dom-name(#3328)6d9b14fno-unnecessary-boolean-comparison(#3349)00d90d4no-useless-compound-assignment(#3355)ddf347ano-useless-delete-check(#3359)2712e16no-useless-logical-operand(#3352)8689080no-xor-as-exponentiation(#3356)5b1952bprefer-array-from-async(#3370)b2bf08fprefer-array-iterable-methods(#3358)e32a7c3prefer-boolean-return(#3340)084bb9eprefer-continue(#3347)c374e14prefer-flat-math-min-max(#3341)3f0a2ceprefer-hoisting-branch-code(#3369)00d8a9bprefer-math-constants(#3309)6ee7dd8prefer-promise-with-resolvers(#3322)e880d29prefer-regexp-escape(#3367)dec6c31prefer-single-replace(#3353)9117778prefer-unary-minus(#3354)98c6f38prefer-url-can-parse(#3366)ba55624prefer-while-loop-condition(#3344)ce538b7Improvements
42abe7434ca8f6d7ce07eprefer-short-arrow-method: Remove fromrecommendedpreset (#3345)0cfd77aprefer-type-literal-last: Remove fromunopinionatedpreset and stop checking intersection types (#3320)447c665consistent-boolean-name: Do not check destructured bindings (#3324)fb0cfe0logical-assignment-operators: Do not assume the base rule'sdefaultOptionsexist (#3321)253e25flogical-assignment-operators: Improve error message (#3302)3ec8fecname-replacements: Add more default replacements (#3365)f968bf3new-for-builtins: Cover more builtins (#3361)e04ac43no-array-splice: Only report fresh, non-escaping local arrays (#3301)babb873no-break-in-nested-loop: Handle unlabeledcontinuein nestedswitchstatements (#3335)ca893bano-declarations-before-early-exit: Ignore initializers containingawaitoryield(#3303)6d98190no-incorrect-template-string-interpolation: Remove fromunopinionatedpreset and fix false-positive (#3319)39dc546no-manually-wrapped-comments: Ignore some more comments (#3292)a545dfeno-named-default: Don't drop comments in autofix (#3306)44e7361no-unsafe-property-key: Allow intrinsic string-mapping types as keys (#3343)ba6020fno-useless-coercion: Flag+value,value + '', andvalue.toString()idioms (#3338)23a52f6no-useless-undefined: Flagreturn undefinedforvoidreturn type (#3334)488d5e3prefer-array-find: Add.filter(…).slice(-1)support (#3360)b6ea1e2prefer-early-return: Fix lexical declaration autofixes (#3325)e7771bdprefer-identifier-import-export-specifiers: Check import attribute keys (#3287)fec43d2prefer-includes-over-repeated-comparisons: Ignore distinct expressions compared againstundefined(#3308)78858ecprefer-minimal-ternary: Report dynamic computed-key swaps (#3300)72879c4prefer-number-properties: AddparseFloatsupport (#3307)4b891d3prefer-object-iterable-methods: Preserve TypeScript casts on value access (#3327)d3a4d39v67.0.0Compare Source
New rules
consistent-boolean-name(#3237)8be0920logical-assignment-operators(#3246)7046694no-array-splice(#3235)d1143a9no-invalid-argument-count(#3243)ec091a9no-non-function-verb-prefix(#3242)5c32dd0no-top-level-assignment-in-function(#3234)e5ff667no-uncalled-method(#3231)f65ac01no-unreadable-for-of-expression(#3248)a8c7f89no-useless-coercion(#3283)3c76922no-useless-continue(#3276)5fd7d25no-useless-override(#3271)f503289operator-assignment(#3249)65ef58cprefer-array-slice(#3233)d9bce20prefer-else-if(#3232)98c2c2eprefer-has-check(#3250)a8d380dprefer-map-from-entries(#3255)01c0f82Improvements
no-unreadable-new-expression: Remove fromrecommendedpreset (#3285)c9f452ecomment-content: Remove fromrecommendedpreset (#3269)21cce8bcomment-content: AddcheckUniformCaseoption (#3269)21cce8bconsistent-class-member-order: Group static methods with other static members (#3239)8f4de02consistent-class-member-order: Improve error message (#3264)47f9f21dom-node-dataset: Flag.datasetassigned to a variable withpreferAttributes(#3268)79198ccno-array-reduce: SuggestMath.sumPrecise()for sum reduces (#3261)081936dno-return-array-push: Disallow usingpush()andunshift()return values (#3244)d9ea7abno-unreadable-array-destructuring: Disallow property targets (#3245)8b50359no-unreadable-object-destructuring: Disallow property targets (#3245)8b50359no-useless-fallback-in-spread: AddcheckTernaryoption (#3284)b2496fcprefer-logical-operator-over-ternary: Improve nullish ternary detection (#3240)4014a1eprefer-minimal-ternary: AddcheckComputedMemberAccessoption (#3241)cf4c014prefer-scoped-selector: Only apply to combined selectors (#3263)d715badprefer-scoped-selector: Report partially-scoped selector lists (#3259)cf88cddprefer-type-literal-last: Keepnullandundefinedlast (#3281)f6a9dceno-array-callback-reference: Harden the rule (#3230)dcc0cf8no-declarations-before-early-exit: Harden side-effect detection (#3238)1bad677no-declarations-before-early-exit: Ignore React hook calls (#3280)de47dcecomment-content: Skip non-prose comments (#3236)9c85b1fno-empty-file: Don't report non-empty files parsed by a plain-text parser (#3270)3b8b9a4no-unsafe-property-key: Don't flagunique symbolkeys (#3278)3fa567eno-unsafe-property-key: Ignore template literal types (#3247)b8d9602v66.0.0Compare Source
Breaking
93164fb93164fbno-array-for-eachrule tono-for-each(#3216)b87c8a9no-hex-escaperule (#3202)d68b09eprefer-unicode-code-point-escapes, which covers more cases.New rules
class-reference-in-static-methods(#3154)bbeb92fcomment-content(#3104)d14d0fdconsistent-class-member-order(#3226)d116a6bconsistent-export-decorator-position(#3175)9302e8dconsistent-function-style(#3137)a86fe5econsistent-optional-chaining(#3195)c07bf4eexplicit-timer-delay(#2814)29ae4ebid-match(#3109)d39bfa3max-nested-calls(#3183)0763b75no-asterisk-prefix-in-documentation-comments(#3191)4a95ff6no-break-in-nested-loop(#3148)41648c1no-computed-property-existence-check(#3151)af0e3c4no-confusing-array-with(#3178)95a748bno-declarations-before-early-exit(#3139)f7241c8no-duplicate-loops(#3142)745e9edno-error-property-assignment(#3114)bf9d72eno-global-object-property-assignment(#3136)b03927eno-incorrect-template-string-interpolation(#3162)32380f9no-mismatched-map-key(#3192)154049fno-negated-array-predicate(#3203)6ba7506no-negated-comparison(#3149)5733173no-object-methods-with-collections(#3194)c9ffbf9no-optional-chaining-on-undeclared-variable(#3223)74be15eno-redundant-comparison(#3068)115837dno-return-array-push(#3098)b8735b0no-subtraction-comparison(#3123)178184bno-top-level-side-effects(#3184)442fba3no-undeclared-class-members(#3153)93cbfc0no-unnecessary-global-this(#3161)a9e2c65no-unnecessary-splice(#3124)646ad09no-unreadable-new-expression(#3113)6ae57a9no-unreadable-object-destructuring(#3160)1696abdno-unsafe-buffer-conversion(#3174)a85f2c6no-unsafe-dom-html(#3218)c70380ano-unsafe-property-key(#3227)d1b6ba7no-unsafe-string-replacement(#3120)e097996no-useless-boolean-cast(#3097)b55d2f8no-useless-concat(#3146)5a88edeno-useless-else(#3152)a99a914no-useless-recursion(#3150)d7ecd39no-useless-template-literals(#3225)b752111prefer-add-event-listener-options(#3169)347abffprefer-array-from-map(#3158)584d39dprefer-await(#3147)15632b6prefer-direct-iteration(#3107)0e2fcfdprefer-dispose(#3085)ce29c25prefer-dom-node-html-methods(#3119)1887853prefer-early-return(#3131)eaca182prefer-global-number-constants(#3127)3c7c767prefer-identifier-import-export-specifiers(#3134)b222909prefer-iterable-in-constructor(#3129)5d76a2dprefer-iterator-to-array(#3094)21eb45bprefer-location-assign(#3132)a064465prefer-minimal-ternary(#3222)9c952e0prefer-number-coercion(#3105)2e6696dprefer-number-is-safe-integer(#3073)55d9f7eprefer-object-define-properties(#3189)ced7bcdprefer-object-destructuring-defaults(#3210)d52f71bprefer-object-iterable-methods(#3156)825fbc0prefer-path2d(#3187)a131574prefer-private-class-fields(#3116)4b2273eprefer-scoped-selector(#3099)2c6eca5prefer-short-arrow-method(#3118)745cd27prefer-simple-sort-comparator(#3081)72d12e5prefer-single-array-predicate(#3164)cd42516prefer-single-object-destructuring(#3163)c08a8fbprefer-smaller-scope(#3206)4374b0eprefer-temporal(#3075)74c55afprefer-type-literal-last(#3121)9967938prefer-uint8array-base64(#3086)254e2e0prefer-unicode-code-point-escapes(#3202) [d68b09e](https://redirect.github.com/sindresorhus/eslint-plugin-unConfiguration
📅 Schedule: (UTC)
* 0-3 1 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.