Skip to content

chore: fix typo in helper module - #3918

Merged
ST-DDT merged 1 commit into
faker-js:nextfrom
hiSandog:fix/small-cleanup-20260625
Jun 25, 2026
Merged

ST-DDT merged 1 commit into
faker-js:nextfrom
hiSandog:fix/small-cleanup-20260625

Conversation

@hiSandog

Copy link
Copy Markdown
Contributor

Summary

  • Rename the internal RANGE_ALPHANUMEMRIC_REG constant to RANGE_ALPHANUMERIC_REG.
  • Keep the existing regular expression and behavior unchanged.

Testing

  • git diff --check
  • pnpm exec prettier --check src/modules/helpers/index.ts
  • pnpm exec vitest run test/modules/helpers.spec.ts
@hiSandog
hiSandog requested a review from a team as a code owner June 25, 2026 03:52
@netlify

netlify Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8480539
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a3ca60c197105000825424c
😎 Deploy Preview https://deploy-preview-3918.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.84%. Comparing base (4798749) to head (8480539).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3918   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         914      914           
  Lines        3215     3215           
  Branches      591      591           
=======================================
  Hits         3178     3178           
  Misses         33       33           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/helpers/index.ts 94.84% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@ST-DDT
ST-DDT requested a review from Copilot June 25, 2026 04:50
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Jun 25, 2026
@ST-DDT ST-DDT added this to the v10.x milestone Jun 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames an internal regex constant in SimpleHelpersModule.fromRegExp() to fix a typo while keeping the regex itself and runtime behavior unchanged.

Changes:

  • Rename RANGE_ALPHANUMEMRIC_REG → RANGE_ALPHANUMERIC_REG.
  • Update all in-method references to the renamed constant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ST-DDT ST-DDT changed the title Fix alphanumeric regex constant typo Jun 25, 2026
@ST-DDT
ST-DDT added this pull request to the merge queue Jun 25, 2026
Merged via the queue into faker-js:next with commit a036fcd Jun 25, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent

4 participants