refactor: extract shared NumberOrRange type - #3939
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3939 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 924 924
Lines 3224 3224
Branches 585 585
=======================================
Hits 3189 3189
Misses 31 31
Partials 4 4
🚀 New features to boost your workflow:
|
1e4fbaa to
ba201fc
Compare
|
Note: this is no longer detected as option like if used as standalone parametern. https://fakerjs.dev/api/string.html#sample
https://deploy-preview-3939.fakerjs.dev/api/string.html#sample
Should we remove jsdoc |
I not really sure yet, while working on the doc script implementation, I was already thinking why there is only |
|
If you want to restore the previous behavior, you may need to look at this: faker/scripts/apidocs/processing/parameter.ts Line 173 in 58394eb Though I'm not sure the parameter is an object type in the first place. Stepping away from the previous behavior for this case, may be an option as well. |
Thanks for the context, I won't have time today to work on that, earliest tomorrow evening. |
ba201fc to
92a370d
Compare
92a370d to
d8249b1
Compare
d8249b1 to
951171a
Compare
951171a to
f53525b
Compare




related to #1443
Preview: