processor_labels: add support for record accessor in values - #9841
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
force-pushed
the
labels-record-accessor
branch
from
January 17, 2025 03:39
ebc1d3a to
daad13e
Compare
…anges Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
marked this pull request as ready for review
January 17, 2025 22:37
edsiper
requested review from
fujimotos,
koleini and
leonardo-albertovich
as code owners
January 17, 2025 22:37
cosmo0920
reviewed
Jan 20, 2025
| } | ||
|
|
||
| TEST_LIST = { | ||
| #ifdef FLB_HAVE_METRICS |
Contributor
There was a problem hiding this comment.
This is just my curiosity but do we need to use this if def for test cases? This is because when disabling FLB_HAVE_METRICS, the defined test cases are not effective under this condition.
Member
Author
There was a problem hiding this comment.
hmm maybe we don't need it... I don't think metrics are optional anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label processors allow to manipulate the labels from metrics, this PR extends the actions
insert,updateandupsertto support a record accessor pattern that helps to use the$TAGvariable that can be populated dinamically, e.g:Fluent Bit output:
This PR also adds a new unit test for the processor.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.