Fix upload response structure - #843
Merged
Merged
Conversation
fsouza
approved these changes
Jun 26, 2022
fsouza
left a comment
fsouza
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks for fixing.
Do you think we could add a failing test? Or a failing example to the examples folder? I can merge this one and we can take care of testing in a follow-up though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API response returned for the Upload Endpoints by the fake-gcs-server differs from the response documented in Google for the
insertendpoint.Reference: https://cloud.google.com/storage/docs/json_api/v1/objects/insert#response