Do not read the objects data on list - #873
Merged
Merged
Conversation
Owner
|
Hey @ironsmile, thanks for keeping working on this! Can you take a look at the test failure? |
Contributor
Author
|
Certainly! Did not realize there are failing tests originally. |
This optimization takes advantage of the fact that the object metadata could now be read from disk without reading its data. Previously the whole file was read from disk in order to obtain its size and nothing more. Instead, now a simple Stat is used.
fsouza
force-pushed
the
do-not-read-object-data-on-list
branch
from
May 3, 2023 03:13
0c71dec to
0bf4764
Compare
fsouza
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am back with my object listing improvements 😄
This optimization takes advantage of the fact that the object metadata
could now be read from disk without reading its data. Previously the
whole file was read from disk in order to obtain its size and nothing
more. Instead, now a simple Stat is used.