Use error structs instead of duplicated strings #102
Merged
+182
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all errors are just strings. They have all one thing in common: They identify a field that caused the error. Therefore I created
DecodeError
struct that hold this information.The next batch of errors is about parsing a certain type. They all have the information about why the parsing failed and additionally what was the expected and actual value. Therefore I created
ParseError
.Last similarity in all errors that I found was when handling unconvertible types. In contrast to parsing errors, they do not have any parsing error as the appropriate parser could not be even found. Therefore I created
UnconvertibleTypeError
for them.This allows us to get detailed errors about what went wrong in the decoding process, it helps with the code clarity - lot of duplicate messages were joined to a single struct. And more importantly, what was my main motivation, it allows me to join the errors together when I use custom nested decoder.