Skip to content

fix: Evaluation time in Goldfish query comparator #20425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spiridonov merged 1 commit into from
Jan 13, 2026
Merged

fix: Evaluation time in Goldfish query comparator #20425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/querytee/goldfish/comparator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func CompareResponses(sample *goldfish.QuerySample, cellAResp, cellBResp *Respon
// it is also possible we match some other unexpected cases
// where the hashes differ but the data is equivalent within tolerance (empty matrix?)

_, err := comparator.Compare(cellAResp.Body, cellBResp.Body, time.Time{})
_, err := comparator.Compare(cellAResp.Body, cellBResp.Body, sample.SampledAt)
if err == nil {
result.ComparisonStatus = goldfish.ComparisonStatusMatch
result.DifferenceDetails["tolerance_match"] = true
Expand Down